Add composite action to upload Debian artifacts to Artifactory#1
Add composite action to upload Debian artifacts to Artifactory#1quic-viskuma merged 1 commit intoqualcomm-linux:mainfrom
Conversation
|
@copilot Please review this PR |
lool
left a comment
lool
left a comment
There was a problem hiding this comment.
Looks great, thanks for this! I left many review comments, but they are mostly fairly minor.
Please, could you also set build.name and build.number based on sensible values, perhaps without allow this in overrides? I'd suggest using GH org-name + repo-name as build.name, but could also be something longer, and GH run id + build attempt id as build.number, but again, could be something longer.
|
Could we also add a tiny README.md with a high-level summary? and I guess our usual battery of static analysis checks :D |
quic-viskuma
force-pushed
the
main
branch
3 times, most recently
from
ad7ea20 to
85918b5
Compare
Will add README and static checks in seperate PR |
This action parses a .changes file and uploads associated Debian source and binary artifacts to a specified Artifactory repository. It supports provenance tagging, architecture detection, and metadata validation. Includes setup for JFrog CLI and dynamic property assignment for APT-compatible publishing. Signed-off-by: VISHAL KUMAR <viskuma@qti.qualcomm.com>
lool
left a comment
lool
left a comment
There was a problem hiding this comment.
Looks good, thanks for making the changes
FYI, copyright checks are failing because it's an empty repo
Perhaps consider adding a SPDX header to the workflow and a top-level LICENSE file (BDS-3-Clear)
3 participants
This action parses a .changes file and uploads associated Debian source
and binary artifacts to a specified Artifactory repository.
It supports provenance tagging, architecture detection, and metadata
validation. Includes setup for JFrog CLI and dynamic property assignment
for APT-compatible publishing.